Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fuselage-ui-kit): export SurfaceRender to allow custom surfaces #33901

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Nov 6, 2024

… surfaces

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo added this to the 7.1.0 milestone Nov 6, 2024
Copy link
Contributor

dionisio-bot bot commented Nov 6, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 65cfd74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.41%. Comparing base (f7391a4) to head (65cfd74).
Report is 24 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33901      +/-   ##
===========================================
- Coverage    75.42%   75.41%   -0.02%     
===========================================
  Files          493      493              
  Lines        21499    21505       +6     
  Branches      5337     5337              
===========================================
+ Hits         16215    16217       +2     
- Misses        4644     4648       +4     
  Partials       640      640              
Flag Coverage Δ
unit 75.41% <33.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

github-actions bot commented Nov 6, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33901/
on branch gh-pages at 2024-11-06 19:07 UTC

@ggazzo ggazzo marked this pull request as ready for review November 6, 2024 20:17
@ggazzo ggazzo merged commit 3bd70ee into develop Nov 11, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/export-surface-generator branch November 11, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant