Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cancel subscription confirmation modal #33814

Merged
merged 14 commits into from
Nov 18, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 28, 2024

Proposed changes (including videos or screenshots)

This PR adds a confirmation modal to the cancel subscription action.

Screenshot 2024-10-28 at 15 20 01

Issue(s)

CONN-370

Steps to test or reproduce

  • Access a workspace with Starter license
  • Go to /admin/subscriptions
  • Go to the bottom of the page and click "Cancel subscription"
  • A confirmation modal should appear

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 47c5417

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva added this to the 7.1.0 milestone Oct 28, 2024
Copy link
Contributor

github-actions bot commented Oct 28, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33814/
on branch gh-pages at 2024-11-18 20:42 UTC

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (aed431c) to head (47c5417).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33814   +/-   ##
========================================
  Coverage    75.18%   75.18%           
========================================
  Files          495      495           
  Lines        21600    21600           
  Branches      5362     5362           
========================================
  Hits         16241    16241           
  Misses        4717     4717           
  Partials       642      642           
Flag Coverage Δ
unit 75.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 28, 2024 19:39
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner October 28, 2024 19:39
tassoevan
tassoevan previously approved these changes Oct 31, 2024
tassoevan
tassoevan previously approved these changes Nov 1, 2024
@aleksandernsilva aleksandernsilva force-pushed the feat/cancel-sub-confimation-modal branch from 5955214 to 58cfb3d Compare November 18, 2024 14:52
@casalsgh casalsgh added the stat: QA assured Means it has been tested and approved by a company insider label Nov 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 18, 2024
@casalsgh
Copy link
Contributor

FYI - QA assured by Bárbara as per jira recordo

@aleksandernsilva aleksandernsilva force-pushed the feat/cancel-sub-confimation-modal branch from 58cfb3d to 4d3b869 Compare November 18, 2024 18:22
@kodiakhq kodiakhq bot merged commit 6166555 into develop Nov 18, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the feat/cancel-sub-confimation-modal branch November 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants