-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cancel subscription confirmation modal #33814
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 47c5417 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33814 +/- ##
========================================
Coverage 75.18% 75.18%
========================================
Files 495 495
Lines 21600 21600
Branches 5362 5362
========================================
Hits 16241 16241
Misses 4717 4717
Partials 642 642
Flags with carried forward coverage won't be shown. Click here to find out more.
|
apps/meteor/client/views/admin/subscription/SubscriptionPage.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/subscription/hooks/useCancelSubscriptionModal.spec.tsx
Outdated
Show resolved
Hide resolved
5955214
to
58cfb3d
Compare
FYI - QA assured by Bárbara as per jira recordo |
This reverts commit f044e44.
58cfb3d
to
4d3b869
Compare
Proposed changes (including videos or screenshots)
This PR adds a confirmation modal to the cancel subscription action.
Issue(s)
CONN-370
Steps to test or reproduce
/admin/subscriptions
Further comments