Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: npm install as rocketchat user #33726

Merged
merged 1 commit into from
Oct 23, 2024
Merged

chore: npm install as rocketchat user #33726

merged 1 commit into from
Oct 23, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 23, 2024

backport from #33596

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 23, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 7.1.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: e54bd20

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.0 milestone Oct 23, 2024
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33726/
on branch gh-pages at 2024-10-23 17:34 UTC

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (63ccadc) to head (e54bd20).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33726   +/-   ##
========================================
  Coverage    75.01%   75.01%           
========================================
  Files          480      480           
  Lines        21000    21000           
  Branches      5329     5329           
========================================
  Hits         15754    15754           
  Misses        4619     4619           
  Partials       627      627           
Flag Coverage Δ
unit 75.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review October 23, 2024 17:48
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Oct 23, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 23, 2024
@ggazzo ggazzo merged commit 73ae901 into develop Oct 23, 2024
53 checks passed
@ggazzo ggazzo deleted the chore/npm-as-user branch October 23, 2024 19:05
ggazzo added a commit that referenced this pull request Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants