Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove query field on channels listing #33623

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

ricardogarim
Copy link
Contributor

@ricardogarim ricardogarim commented Oct 17, 2024

This pull request addresses CORE-718 by removing the query param query sent to /api/v1/channels.list endpoint.

Copy link
Contributor

dionisio-bot bot commented Oct 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: abda41c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33623/
on branch gh-pages at 2024-10-17 21:52 UTC

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.85%. Comparing base (c314bb6) to head (abda41c).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33623   +/-   ##
========================================
  Coverage    74.85%   74.85%           
========================================
  Files          470      470           
  Lines        20743    20743           
  Branches      5294     5294           
========================================
  Hits         15528    15528           
  Misses        4595     4595           
  Partials       620      620           
Flag Coverage Δ
unit 74.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review October 17, 2024 15:14
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners October 17, 2024 15:15
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Oct 17, 2024
@scuciatto scuciatto added this to the 7.0 milestone Oct 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 17, 2024
@ggazzo ggazzo merged commit f63d8e2 into develop Oct 17, 2024
10 checks passed
@ggazzo ggazzo deleted the chore/channels-list-query-param branch October 17, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants