Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Remove unused dependencies #33593

Merged
merged 5 commits into from
Oct 16, 2024
Merged

chore!: Remove unused dependencies #33593

merged 5 commits into from
Oct 16, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Oct 15, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

redis - First installed by rocketchat-tutum :kek: (whatever this means)
turndown - First installed by hipchat importer, now deprecated
autolinker - First installed by the autolinker feature, now deprecated
node-abort-controller - Node16+ has its own AbortController, which should work the same.

Moved some @types packages to be in devDependencies instead of regular dependencies, and removed unused types.

Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: d37d90c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/i18n Major
@rocket.chat/rest-typings Major
rocketchat-services Major
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/network-broker Patch
@rocket.chat/core-typings Major
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33593/
on branch gh-pages at 2024-10-16 15:44 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.42%. Comparing base (2b8ac8a) to head (cb3d73e).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33593   +/-   ##
========================================
  Coverage    58.42%   58.42%           
========================================
  Files         2746     2746           
  Lines        66285    66285           
  Branches     15001    15001           
========================================
  Hits         38730    38730           
  Misses       24732    24732           
  Partials      2823     2823           
Flag Coverage Δ
unit 74.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman force-pushed the chore/removesomedeps branch from aa1d925 to 5c658ae Compare October 16, 2024 13:58
@KevLehman KevLehman changed the title chore: remove deps chore!: remove deps Oct 16, 2024
@KevLehman KevLehman changed the title chore!: remove deps chore!: Remove unused dependencies Oct 16, 2024
@KevLehman KevLehman added this to the 7.0 milestone Oct 16, 2024
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@KevLehman KevLehman force-pushed the chore/removesomedeps branch from 5c658ae to 2b8ac8a Compare October 16, 2024 14:57
@dionisio-bot dionisio-bot bot added stat: conflict and removed stat: ready to merge PR tested and approved waiting for merge stat: conflict labels Oct 16, 2024
@KevLehman KevLehman changed the base branch from release-7.0.0 to develop October 16, 2024 15:00
@KevLehman KevLehman marked this pull request as ready for review October 16, 2024 15:01
@KevLehman KevLehman modified the milestones: 7.0, 6.14 Oct 16, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Oct 16, 2024
@KevLehman KevLehman force-pushed the chore/removesomedeps branch from cb3d73e to d37d90c Compare October 16, 2024 15:58
@KevLehman KevLehman requested review from a team as code owners October 16, 2024 15:58
@KevLehman KevLehman requested review from a team as code owners October 16, 2024 15:58
@dionisio-bot dionisio-bot bot added stat: conflict and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 16, 2024
@KevLehman KevLehman changed the base branch from develop to release-7.0.0 October 16, 2024 15:58
@KevLehman KevLehman modified the milestones: 6.14, 7.0 Oct 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 16, 2024
@ggazzo ggazzo merged commit b8b8880 into release-7.0.0 Oct 16, 2024
11 checks passed
@ggazzo ggazzo deleted the chore/removesomedeps branch October 16, 2024 17:28
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants