Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unused stuff related to Storybook #33588

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan added this to the 7.0 milestone Oct 15, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 15, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 9de62fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tassoevan tassoevan requested a review from a team October 15, 2024 16:09
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33588/
on branch gh-pages at 2024-10-15 16:57 UTC

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (8649fb4) to head (9de62fa).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33588      +/-   ##
=================================================
- Coverage          74.80%   74.79%   -0.02%     
=================================================
  Files                468      467       -1     
  Lines              20678    20641      -37     
  Branches            5275     5262      -13     
=================================================
- Hits               15469    15439      -30     
+ Misses              4594     4590       -4     
+ Partials             615      612       -3     
Flag Coverage Δ
unit 74.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review October 15, 2024 17:49
@tassoevan tassoevan force-pushed the chore/unused-stuff-in-storybook branch from 55c7339 to 9de62fa Compare October 15, 2024 17:54
@ggazzo ggazzo merged commit 4fa594f into release-7.0.0 Oct 15, 2024
10 checks passed
@ggazzo ggazzo deleted the chore/unused-stuff-in-storybook branch October 15, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants