Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Aligns Learn More link to the left corner of the modal #33547

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Oct 11, 2024

Proposed changes (including videos or screenshots)

This PR fixes the alignment of the Learn More link to the left corner of the modal's footer.

image

Issue(s)

PASLR-26

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 11, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 11, 2024

⚠️ No Changeset found

Latest commit: 0ee3911

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33547/
on branch gh-pages at 2024-10-15 01:52 UTC

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.64%. Comparing base (11a47b6) to head (0ee3911).
Report is 4 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33547   +/-   ##
==============================================
  Coverage          74.64%   74.64%           
==============================================
  Files                437      437           
  Lines              20485    20485           
  Branches            5252     5252           
==============================================
  Hits               15291    15291           
  Misses              4582     4582           
  Partials             612      612           
Flag Coverage Δ
unit 74.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

MartinSchoeler
MartinSchoeler previously approved these changes Oct 11, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@ggazzo
Copy link
Member

ggazzo commented Oct 11, 2024

Do we have cases where it is expected to be to the right? If not, we would change this in the fuselage

@lucas-a-pelegrino
Copy link
Member Author

Do we have cases where it is expected to be to the right? If not, we would change this in the fuselage

I'm not sure if we have instances of these sort of content aligned solely on the right.

@ggazzo ggazzo dismissed MartinSchoeler’s stale review October 11, 2024 20:51

The merge-base changed after approval.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 09c1b34 to 3099c34 Compare October 11, 2024 21:14
@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.0 milestone Oct 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 12, 2024
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if its not a break change or has no 7.0.0 point to develop

@lucas-a-pelegrino
Copy link
Member Author

if its not a break change or has no 7.0.0 point to develop

It's part of the new Private Apps Restrictions project, that changes the modal's text and adds a link to the docs.

It should be targeting 7.0.0, shouldn't it?

@MartinSchoeler
Copy link
Contributor

if its not a break change or has no 7.0.0 point to develop

Technically this is a regression fix for an issue added here #33316

I'll change the title to better inform that

@MartinSchoeler MartinSchoeler changed the title chore: Aligns Learn More link to the left corner of the modal regression: Aligns Learn More link to the left corner of the modal Oct 14, 2024
@MartinSchoeler MartinSchoeler requested a review from ggazzo October 14, 2024 13:28
@MartinSchoeler MartinSchoeler marked this pull request as ready for review October 14, 2024 17:11
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner October 14, 2024 17:11
@ggazzo ggazzo requested review from a team as code owners October 15, 2024 00:45
@ggazzo ggazzo merged commit dfe5fd8 into release-7.0.0 Oct 15, 2024
50 checks passed
@ggazzo ggazzo deleted the fix/PASLR-26 branch October 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants