-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: Aligns Learn More link to the left corner of the modal #33547
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33547 +/- ##
==============================================
Coverage 74.64% 74.64%
==============================================
Files 437 437
Lines 20485 20485
Branches 5252 5252
==============================================
Hits 15291 15291
Misses 4582 4582
Partials 612 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
e0f3b88
to
1134f3a
Compare
Do we have cases where it is expected to be to the right? If not, we would change this in the fuselage |
I'm not sure if we have instances of these sort of content aligned solely on the right. |
The merge-base changed after approval.
09c1b34
to
3099c34
Compare
1134f3a
to
5cdaf34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if its not a break change or has no 7.0.0 point to develop
It's part of the new Private Apps Restrictions project, that changes the modal's text and adds a link to the docs. It should be targeting 7.0.0, shouldn't it? |
Technically this is a regression fix for an issue added here #33316 I'll change the title to better inform that |
1953761
to
3c79c0a
Compare
Proposed changes (including videos or screenshots)
This PR fixes the alignment of the Learn More link to the left corner of the modal's footer.
Issue(s)
PASLR-26
Steps to test or reproduce
Further comments