Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: add conditional support to query and fields query params #33544

Merged
merged 5 commits into from
Oct 11, 2024
Merged

chore!: add conditional support to query and fields query params #33544

merged 5 commits into from
Oct 11, 2024

Conversation

ricardogarim
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bd59574

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 11, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.14.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@ricardogarim ricardogarim added this to the 7.0 milestone Oct 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 11, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-11 21:12 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.59%. Comparing base (bd5a5ff) to head (bd59574).
Report is 83 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33544   +/-   ##
==============================================
  Coverage          58.59%   58.59%           
==============================================
  Files               2739     2739           
  Lines              65696    65696           
  Branches           14826    14826           
==============================================
  Hits               38496    38496           
  Misses             24420    24420           
  Partials            2780     2780
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ricardogarim ricardogarim marked this pull request as ready for review October 11, 2024 19:42
@ricardogarim ricardogarim changed the base branch from develop to release-7.0.0 October 11, 2024 19:43
@ricardogarim ricardogarim dismissed MarcosSpessatto’s stale review October 11, 2024 19:43

The base branch was changed.

@ricardogarim ricardogarim added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 11, 2024
@ricardogarim ricardogarim changed the title chore: add conditional support to query and fields query params chore!: add conditional support to query and fields query params Oct 11, 2024
@ricardogarim ricardogarim merged commit 2e8b9a0 into release-7.0.0 Oct 11, 2024
54 checks passed
@ricardogarim ricardogarim deleted the chore/add-conditional-support-to-query-and-fields branch October 11, 2024 21:02
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
bab25f7 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
cdcacad 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ricardogarim added a commit that referenced this pull request Oct 11, 2024
@ricardogarim
merge from #33544
bae1733
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
9450210 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
@ricardogarim @MartinSchoeler
chore!: add conditional support to query and fields query params (#33544
898aabf 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
fb2a3ec 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
f633c7e 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
5a06e00 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
@ricardogarim @ggazzo
chore!: add conditional support to query and fields query params (#33544
8865653 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
@ricardogarim @abhinavkrin
chore!: add conditional support to query and fields query params (#33544
109a3c0 
)

* chore: add conditional support to query and fields query params

* chore: add conditional support to query and fields query params

* chore: remove dummyRoute

* chore: add comment on hasSupportedRoutes

* chore: change logger to point to version 8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ricardogarim @MarcosSpessatto