-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Only room creator can set the E2EE room key for the first time #33520
fix!: Only room creator can set the E2EE room key for the first time #33520
Conversation
🦋 Changeset detectedLatest commit: b619923 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33520 +/- ##
================================================
Coverage ? 75.70%
================================================
Files ? 432
Lines ? 19919
Branches ? 5084
================================================
Hits ? 15079
Misses ? 4269
Partials ? 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
e6e7faf
to
9196ec4
Compare
9196ec4
to
af9f94a
Compare
fa2b5a3
to
ba4ed73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should change this to a fix instead
The merge-base changed after approval.
ba4ed73
to
9260ef7
Compare
Proposed changes (including videos or screenshots)
room.u._id
is the same as the user requesting. Currently anyone invited to the room can set the roomKeyID (and the E2EE key) before the owner gets the key, which can cause race conditions and leave the room in a bad state.Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-79
Steps to test or reproduce
Further comments