Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add External Link icon to Upgrade Button #33488

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Oct 8, 2024

Proposed changes (including videos or screenshots)

This PR simply adds the external link icon to the upgrade subscription button on the private apps page.

Issue(s)

PASLR-28

Steps to test or reproduce

Further comments

@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Oct 8, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: cf961d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lucas-a-pelegrino lucas-a-pelegrino changed the base branch from develop to release-7.0.0 October 8, 2024 13:02
@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.0 milestone Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33488/
on branch gh-pages at 2024-10-14 17:33 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.70%. Comparing base (ebe7a29) to head (65f6b41).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #33488   +/-   ##
==============================================
  Coverage          75.70%   75.70%           
==============================================
  Files                432      432           
  Lines              19919    19919           
  Branches            5084     5084           
==============================================
  Hits               15079    15079           
  Misses              4269     4269           
  Partials             571      571           
Flag Coverage Δ
unit 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review October 8, 2024 14:40
@lucas-a-pelegrino lucas-a-pelegrino requested a review from a team as a code owner October 8, 2024 14:40
tassoevan
tassoevan previously approved these changes Oct 8, 2024
@ggazzo ggazzo dismissed tassoevan’s stale review October 8, 2024 17:42

The merge-base changed after approval.

@ggazzo ggazzo requested review from a team as code owners October 8, 2024 17:42
tassoevan
tassoevan previously approved these changes Oct 9, 2024
@sampaiodiego sampaiodiego dismissed tassoevan’s stale review October 9, 2024 15:20

The merge-base changed after approval.

@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
MartinSchoeler
MartinSchoeler previously approved these changes Oct 11, 2024
@ggazzo ggazzo dismissed MartinSchoeler’s stale review October 11, 2024 17:03

The merge-base changed after approval.

MartinSchoeler
MartinSchoeler previously approved these changes Oct 11, 2024
@MartinSchoeler MartinSchoeler added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 11, 2024
tassoevan
tassoevan previously approved these changes Oct 11, 2024
@ggazzo ggazzo dismissed stale reviews from tassoevan and MartinSchoeler October 11, 2024 20:51

The merge-base changed after approval.

@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from 09c1b34 to 3099c34 Compare October 11, 2024 21:14
tassoevan
tassoevan previously approved these changes Oct 12, 2024
@ggazzo ggazzo dismissed tassoevan’s stale review October 14, 2024 14:44

The merge-base changed after approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants