Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Grandfathered private apps texts #33468

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

lucas-a-pelegrino
Copy link
Member

@lucas-a-pelegrino lucas-a-pelegrino commented Oct 5, 2024

Proposed changes (including videos or screenshots)

This PR updates the text used to warn the user of grandfathered apps.

Issue(s)

PASLR-26

Steps to test or reproduce

Further comments

image

@lucas-a-pelegrino lucas-a-pelegrino added this to the 7.0 milestone Oct 5, 2024
@lucas-a-pelegrino lucas-a-pelegrino self-assigned this Oct 5, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 5, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 5, 2024

⚠️ No Changeset found

Latest commit: caae23a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 5, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-07 18:12 UTC

Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.32%. Comparing base (4c5a47d) to head (caae23a).
Report is 1 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-7.0.0   #33468      +/-   ##
=================================================
- Coverage          75.66%   75.32%   -0.34%     
=================================================
  Files                430      383      -47     
  Lines              19904    19383     -521     
  Branches            5079     4980      -99     
=================================================
- Hits               15060    14601     -459     
+ Misses              4273     4212      -61     
+ Partials             571      570       -1     
Flag Coverage Δ
unit 75.32% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lucas-a-pelegrino lucas-a-pelegrino marked this pull request as ready for review October 5, 2024 03:33
Co-authored-by: Matheus Barbosa Silva <[email protected]>
@lucas-a-pelegrino lucas-a-pelegrino merged commit db12f46 into release-7.0.0 Oct 7, 2024
53 of 75 checks passed
@lucas-a-pelegrino lucas-a-pelegrino deleted the chore/PASLR-26 branch October 7, 2024 18:12
ggazzo pushed a commit that referenced this pull request Oct 8, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
sampaiodiego pushed a commit that referenced this pull request Oct 9, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
abhinavkrin pushed a commit that referenced this pull request Oct 11, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 11, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 14, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
MartinSchoeler pushed a commit that referenced this pull request Oct 14, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 15, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
* chore: updates grandfathered private app texts

* chore: removes outdated translations

* fix: applies code review requested changes

Co-authored-by: Matheus Barbosa Silva <[email protected]>

---------

Co-authored-by: Matheus Barbosa Silva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants