-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating path responseBy
would create a conflict on responseBy
#33412
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 6844fa3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33412 +/- ##
===========================================
+ Coverage 58.41% 58.43% +0.02%
===========================================
Files 2744 2745 +1
Lines 66247 66337 +90
Branches 14988 15007 +19
===========================================
+ Hits 38697 38764 +67
- Misses 24730 24749 +19
- Partials 2820 2824 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omnichannel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KevLehman If possible, adding a unit test that verifies this scenario might be a good idea.
apps/meteor/tests/unit/server/livechat/hooks/markRoomResponded.spec.ts
Outdated
Show resolved
Hide resolved
We need this for v6, could you create a backport? |
Proposed changes (including videos or screenshots)
getAgentLastMessageTsUpdateQuery
responseBy
object in a way that won't create a conflict.Issue(s)
https://rocketchat.atlassian.net/browse/CORE-703
Steps to test or reproduce
waitingResponse: true
flag on the room object and send a message again. It should fail.When these preconditions are met, Mongo will get an update similar to:
Since the same update is modifying the same property on different ways, Mongo issues a "ConflictError" and blocks the update.
Further comments