-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removed symbolic link to apps engine #33406
Conversation
Looks like this PR is ready to merge! 🎉 |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33406 +/- ##
========================================
Coverage 58.57% 58.57%
========================================
Files 2737 2737
Lines 65763 65763
Branches 14826 14826
========================================
Hits 38521 38521
Misses 24463 24463
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
Since apps engine lives inside the monorepo there is no reason to rebuild just to accommodate js engines, the output should be good with no workarounds
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments