-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Title missing in thread list for threads starting with attachment in E2EE rooms #33375
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 3bab4e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33375 +/- ##
===========================================
+ Coverage 58.57% 59.60% +1.03%
===========================================
Files 2737 2601 -136
Lines 65763 63578 -2185
Branches 14826 14255 -571
===========================================
- Hits 38521 37896 -625
+ Misses 24463 22976 -1487
+ Partials 2779 2706 -73
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hugocostadev , I tested the branch and everything seem to be working fine 👌
Just the minor adjustment to the changeset.
Btw, I belive we could improve this PR's title to be a bit more descriptive (e.g fix: Title missing in thread list for threads starting with attachment in E2EE rooms
)
I know my title suggestion is a bit long but it's just an example 😉
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
…t in E2EE rooms (#33375)
Proposed changes (including videos or screenshots)
The thread title is not showing on the threads list if the thread starts with an image or a file
Before:
Now:
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-51