Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Title missing in thread list for threads starting with attachment in E2EE rooms #33375

Merged
merged 8 commits into from
Oct 3, 2024

Conversation

hugocostadev
Copy link
Contributor

Proposed changes (including videos or screenshots)

The thread title is not showing on the threads list if the thread starts with an image or a file

Before:
image

Now:
image

Issue(s)

Steps to test or reproduce

  1. Open an E2EE channel
  2. Send an image or file to the channel
  3. Hover the image → Start the thread
  4. Send a message inside the thread
  5. On the top of the channel, click on “Threads” to see the threads list

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-51

@hugocostadev hugocostadev added this to the 6.14 milestone Sep 26, 2024
Copy link
Contributor

dionisio-bot bot commented Sep 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 3bab4e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 26, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-03 14:18 UTC

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.60%. Comparing base (f2844aa) to head (3bab4e2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33375      +/-   ##
===========================================
+ Coverage    58.57%   59.60%   +1.03%     
===========================================
  Files         2737     2601     -136     
  Lines        65763    63578    -2185     
  Branches     14826    14255     -571     
===========================================
- Hits         38521    37896     -625     
+ Misses       24463    22976    -1487     
+ Partials      2779     2706      -73     
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review September 26, 2024 14:24
@hugocostadev hugocostadev requested a review from a team as a code owner September 26, 2024 14:24
Copy link
Contributor

@aleksandernsilva aleksandernsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hugocostadev , I tested the branch and everything seem to be working fine 👌
Just the minor adjustment to the changeset.

Btw, I belive we could improve this PR's title to be a bit more descriptive (e.g fix: Title missing in thread list for threads starting with attachment in E2EE rooms)

I know my title suggestion is a bit long but it's just an example 😉

.changeset/moody-phones-admire.md Outdated Show resolved Hide resolved
@hugocostadev hugocostadev changed the title fix: E2EE room > thread list with attachment fix: Title missing in thread list for threads starting with attachment in E2EE rooms Sep 27, 2024
Co-authored-by: Aleksander Nicacio da Silva <[email protected]>
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 3, 2024
@kodiakhq kodiakhq bot merged commit d661782 into develop Oct 3, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/e2ee-thread-with-attachment branch October 3, 2024 14:18
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants