Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve stats cronjob scheduling #33311

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Sep 17, 2024

Proposed changes (including videos or screenshots)

Since multiple instances can be spun up at different times, it means multiple cronjobs could be scheduled to run at different times, each one of them would collect ALL statistics data once again and send it back. I'm changing to check whether the latest statistics data generated was sent in the last 24h and only generate new data if that was not the case.

Issue(s)

OPI-42

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: 33c1a83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 17, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33311/
on branch gh-pages at 2024-11-18 18:47 UTC

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.18%. Comparing base (590a449) to head (33c1a83).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33311   +/-   ##
========================================
  Coverage    75.18%   75.18%           
========================================
  Files          495      495           
  Lines        21600    21600           
  Branches      5362     5362           
========================================
  Hits         16241    16241           
  Misses        4717     4717           
  Partials       642      642           
Flag Coverage Δ
unit 75.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@sampaiodiego sampaiodiego force-pushed the chore-improve-stats-cron branch from 5406e47 to 65c816c Compare October 9, 2024 19:07
@sampaiodiego sampaiodiego marked this pull request as ready for review October 9, 2024 19:07
@sampaiodiego sampaiodiego requested a review from a team as a code owner October 9, 2024 19:07
@sampaiodiego sampaiodiego force-pushed the chore-improve-stats-cron branch from 65c816c to 78bda3d Compare November 7, 2024 15:14
KevLehman
KevLehman previously approved these changes Nov 18, 2024
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Nov 18, 2024
@sampaiodiego sampaiodiego added this to the 7.1.0 milestone Nov 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 18, 2024
@kodiakhq kodiakhq bot merged commit 8839f86 into develop Nov 18, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the chore-improve-stats-cron branch November 18, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants