feat: Fetch avatars using user id #33214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: ebb5e49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33214 +/- ##
===========================================
+ Coverage 75.73% 75.88% +0.14%
===========================================
Files 507 507
Lines 21799 21938 +139
Branches 5343 5351 +8
===========================================
+ Hits 16509 16647 +138
Misses 4648 4648
- Partials 642 643 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
pierre-lehnen-rc
requested changes
Sep 9, 2024
|
sampaiodiego
previously approved these changes
Sep 16, 2024
I was very unsure about how to proceed with tests, but I think I can make some end-to-end cases (I found some tests for assets so I think they should be similar). I'll do them whenever I can, reverting this to draft for now. |
KevLehman
reviewed
Sep 23, 2024
gabriellsh
force-pushed
the
fetchAvatarById
branch
from
ac9694c to
2cca426
Compare
ggazzo
reviewed
Nov 7, 2024
pierre-lehnen-rc
previously approved these changes
Nov 7, 2024
Co-authored-by: Marcos Spessatto Defendi <[email protected]>
pierre-lehnen-rc
previously approved these changes
Nov 7, 2024
sampaiodiego
requested changes
Nov 7, 2024
MarcosSpessatto
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
sampaiodiego
approved these changes
Nov 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created a new route
<workspace>/avatar/uid/<userID>which allows fetching avatars using the user's ID instead of just using username.This is being done to help improve performance in places where we only have access to user id. This way we avoid making an API call just to get the user's username.
This route will also return the generated SVG avatars (Initial letter with colored background) but does not allow using
@to force returning this fallback, since a userID is expected and the fallback is based on username/name.Issue(s)
CORE-673
Steps to test or reproduce
Further comments