-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: new stats #33013
chore: new stats #33013
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33013 +/- ##
========================================
Coverage 58.42% 58.42%
========================================
Files 2746 2746
Lines 66285 66285
Branches 15001 15001
========================================
Hits 38730 38730
Misses 24732 24732
Partials 2823 2823
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm afraid the new queries might be too heavy for large deployments.. I'll take a look at them more carefully..
@hugocostadev you can help testing that as well.. if you can provide some maybe even use https://github.com/KevLehman/filler and expand it to rooms |
@hugocostadev, there might be a cleaner way to handle the Edit: Also, just a thought — it could be worth testing a projection right after the match so we only pass the priorityWeight field along instead of the entire document. This might help optimize things a bit. Updated aggregate query suggestionconst pipeline = [
{
$match: {
t: 'l',
},
},
{
$project: {
priorityWeight: 1,
},
},
{
$group: {
_id: '$priorityWeight',
count: { $sum: 1 },
},
},
]; |
e084596
to
6caaa61
Compare
|
4d7f4b6
to
bbbab1f
Compare
bbbab1f
to
831c994
Compare
the tag |
Proposed changes (including videos or screenshots)
New stats for the cloud stats collector service
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CONN-312