-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: removed reportMessage method #32633
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32633 +/- ##
==============================================
Coverage 59.39% 59.40%
==============================================
Files 2541 2541
Lines 63175 63173 -2
Branches 14220 14220
==============================================
Hits 37525 37525
+ Misses 22935 22933 -2
Partials 2715 2715
Flags with carried forward coverage won't be shown. Click here to find out more. |
fd459bb
to
df2e554
Compare
df2e554
to
79cd7bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The merge-base changed after approval.
ce44882
to
d94b784
Compare
30f6f98
to
8c447cf
Compare
Signed-off-by: Abhinav Kumar <[email protected]>
79cd7bb
to
e7553a3
Compare
Proposed changes (including videos or screenshots)
Removed
reportMessage
method as it has been replaced withchat.reportMessage
.Replaced the client call to the method with the endpoint call.
Issue(s)
Steps to test or reproduce
Further comments
CORE-360