feat: E2EE messages mentions #32510

hugocostadev · 2024-05-28T15:52:23Z

Proposed changes (including videos or screenshots)

In Rocket.Chat, while end-to-end encryption secures user messages in private rooms, it currently does not support the functionality to mention specific users within these encrypted conversations. This limitation reduces the usability and interactivity of the chat, as users cannot directly alert or reference other participants. Enabling mentions in encrypted rooms will enhance communication efficiency and user engagement without compromising the security of the encryption.

Acceptance criteria (DoD)

Functionality Implementation: Users should be able to mention other users, teams, and @ALL and @here in end-to-end encrypted rooms using the '@' symbol followed by the username, exactly the same functionality in non-encrypted rooms.
Autocomplete Feature: As a user types a mention, an autocomplete feature should suggest possible usernames based on the current participants in the room, exactly the same functionality in non-encrypted rooms.
Notification Handling: Users who are mentioned should receive notifications if they have notifications enabled, exactly the same functionality in non-encrypted rooms.
Security Compliance: The implementation of mentions must not compromise the encryption integrity of the message, but it’s not required the mention to be end-to-end encrypted.
Performance Impact: Ensure that the introduction of mentions does not significantly impact the performance and responsiveness of the chat system.
User Experience: The user interface for mentions in encrypted rooms should be seamless and intuitive, without requiring additional steps or complications for the user.
Accessibility and Compatibility: Ensure that mentions are accessible and function consistently across all supported devices and platforms.
Create a new setting

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-8

…mentions

dionisio-bot · 2024-05-28T15:52:27Z

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

changeset-bot · 2024-05-28T15:52:28Z

🦋 Changeset detected

Latest commit: 1eeff2d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages

Name	Type
@rocket.chat/meteor	Minor
@rocket.chat/core-typings	Minor
@rocket.chat/i18n	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/gazzodown	Major
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/rest-typings	Minor
@rocket.chat/ui-contexts	Major
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/mock-providers	Patch
@rocket.chat/web-ui-registration	Major
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Major
@rocket.chat/ui-client	Major
@rocket.chat/ui-video-conf	Major
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2024-05-28T16:07:11Z

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.70%. Comparing base (636d32d) to head (1eeff2d).
Report is 14 commits behind head on develop.

Additional details and impacted files

@@            Coverage Diff            @@
##           develop   #32510    +/-   ##
=========================================
  Coverage    59.70%   59.70%            
=========================================
  Files         2551     2551            
  Lines        62792    62908   +116     
  Branches     14102    14128    +26     
=========================================
+ Hits         37492    37562    +70     
- Misses       22893    22929    +36     
- Partials      2407     2417    +10

Flag	Coverage Δ
unit	`76.90% <71.42%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/mentions/server/Mentions.ts

apps/meteor/client/startup/e2e.ts

.changeset/late-planes-sniff.md

…mentions

MarcosSpessatto

Can we add a description to the PR?

apps/meteor/app/mentions/server/Mentions.ts

apps/meteor/client/startup/e2e.ts

apps/meteor/tests/e2e/e2e-encryption.spec.ts

…mentions

github-actions · 2024-09-17T16:06:54Z

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-20 00:15 UTC

…hAvatarById * 'develop' of github.com:RocketChat/Rocket.Chat: feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) feat: `RoomSidepanel` (#33225) feat: contextualbar based on chat size (#33321) fix: error on sendmessage stub (#33317) fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) fix: Mark as unread not working (#32939) fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) feat: Allow managing association to business units on departments' creation and update (#32682)

* Bump 6.12.1 * fix: message parser being slow to process very long messages with too many symbols (#33254) Co-authored-by: Pierre Lehnen <[email protected]> * fix: Allow to use the token from `room.v` when requesting transcript instead of finding visitor (#33242) Co-authored-by: Kevin Aleman <[email protected]> * fix: Retention Policy cached settings not updated during upgrade procedure (#33265) Co-authored-by: gabriellsh <[email protected]> * fix: imported fixes (#33268) Co-authored-by: Julio A. <[email protected]> * Release 6.12.1 [no ci] * fix: Federation callback not awaiting model call (#33298) * fix: correct parameter order in afterSaveMessage to restore outgoing webhooks and related features (#33295) * feat: New endpoint for listing rooms & discussions from teams (#33177) * chore: Update typings on callbacks to accept less than a full room object (#33305) * fix: resolve avatar download issue on setUsername by refining service selection logic (#33193) * feat: Allow managing association to business units on departments' creation and update (#32682) * fix: Local avatars prioritized over external avatar provider and remove remnant references on client of `Accounts_AvatarExternalProviderUrl` (#33296) Co-authored-by: gabriellsh <[email protected]> * fix: Mark as unread not working (#32939) Co-authored-by: Douglas Fabris <[email protected]> * refactor: Remove old `setreaction` callbacks and use new after/before callbacks (#33309) * fix: `LivechatSessionTaken` webhook event called without `agent` param (#33209) * fix: error on sendmessage stub (#33317) * feat: contextualbar based on chat size (#33321) * feat: `RoomSidepanel` (#33225) Co-authored-by: Guilherme Gazzo <[email protected]> * ci: auto candidate releases (#33325) Co-authored-by: Diego Sampaio <[email protected]> * refactor: Reactions set/unset (#32994) * feat: E2EE messages mentions (#32510) * fix: markdown inconsistency with bold and italics (#33157) * fix: conference calls are shown as "not answered" after they end (#33179) * Release 6.13.0-rc.0 * chore: update E2EE setting text (#33226) * feat: Implement proper accessbility for report user modal (#33294) Co-authored-by: Tasso Evangelista <[email protected]> * fix: imported fixes (#33330) * chore: create network broker package (#33338) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <[email protected]> * chore: move common files to core-services (#33341) * regression: `Sidepanel` color highlight (#33342) * feat: Adds new admin feature preview setting management (#33212) Co-authored-by: Guilherme Gazzo <[email protected]> * fix: Avoid destructuring `connectionData` when value is undefined (#33339) * Release 6.13.0-rc.1 [no ci] * chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) * Bump rocket.chat to 6.14.0-develop (#33366) * ci: use node20 for release action (#33343) --------- Co-authored-by: rocketchat-github-ci <[email protected]> Co-authored-by: dionisio-bot[bot] <117394943+dionisio-bot[bot]@users.noreply.github.com> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Julio A. <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Ricardo Garim <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: Hugo Costa <[email protected]> Co-authored-by: csuadev <[email protected]> Co-authored-by: Henrique Guimarães Ribeiro <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Lucas Pelegrino <[email protected]> Co-authored-by: Trivikram Kamat <[email protected]>

…apped/composer-restriction * 'develop' of github.com:RocketChat/Rocket.Chat: (55 commits) regression: `Sidepanel` sort requires refresh after room update (#33370) ci: use node20 for release action (#33343) Bump rocket.chat to 6.14.0-develop (#33366) chore: replace Meteor._localStorage -> Accounts.storageLocation (#33356) Release 6.13.0-rc.1 fix: Avoid destructuring `connectionData` when value is undefined (#33339) feat: Adds new admin feature preview setting management (#33212) regression: `Sidepanel` color highlight (#33342) chore: move common files to core-services (#33341) feat: Adds new admin feature preview setting management (#33212) chore: create network broker package (#33338) fix: imported fixes (#33330) feat: Implement proper accessbility for report user modal (#33294) chore: update E2EE setting text (#33226) Release 6.13.0-rc.0 fix: conference calls are shown as "not answered" after they end (#33179) fix: markdown inconsistency with bold and italics (#33157) feat: E2EE messages mentions (#32510) refactor: Reactions set/unset (#32994) ci: auto candidate releases (#33325) ...

hugocostadev added 2 commits May 28, 2024 12:51

feat: E2EE messages mentions

1976fff

Merge remote-tracking branch 'origin/develop' into feat/e2e-messages-…

24cdb06

…mentions

ggazzo added the Invalid PR Title label May 28, 2024

hugocostadev changed the title ~~Feat/e2e messages mentions~~ feat: E2EE messages mentions May 28, 2024

ggazzo removed the Invalid PR Title label May 28, 2024

hugocostadev added 3 commits May 28, 2024 13:54

adding E2E_Enabled_Mentions settings

1dafb56

fix: setting description

5442f41

test: adding mention tests

f3656fc

hugocostadev marked this pull request as ready for review June 3, 2024 20:17

hugocostadev requested review from a team as code owners June 3, 2024 20:17

hugocostadev added 2 commits June 3, 2024 17:17

Merge branch 'develop' into feat/e2e-messages-mentions

85a4786

Create late-planes-sniff.md

d12a819

KevLehman reviewed Jun 3, 2024

View reviewed changes

apps/meteor/app/mentions/server/Mentions.ts Outdated Show resolved Hide resolved

apps/meteor/app/mentions/server/Mentions.ts Outdated Show resolved Hide resolved

apps/meteor/client/startup/e2e.ts Outdated Show resolved Hide resolved

hugocostadev added 2 commits June 4, 2024 08:53

Merge branch 'develop' into feat/e2e-messages-mentions

e98ddaf

test: fix flaky keypress behavior

184d931

hugocostadev requested a review from KevLehman June 5, 2024 18:51

hugocostadev added this to the 7.0 milestone Jun 7, 2024

MarcosSpessatto requested changes Jun 11, 2024

View reviewed changes

.changeset/late-planes-sniff.md Outdated Show resolved Hide resolved

fix changeset

8c68d7d

hugocostadev requested a review from MarcosSpessatto June 12, 2024 19:08

Merge remote-tracking branch 'origin/develop' into feat/e2e-messages-…

b94db45

…mentions

diegolmello mentioned this pull request Jun 14, 2024

feat: E2EE messages mentions RocketChat/Rocket.Chat.ReactNative#5744

Merged

10 tasks

MarcosSpessatto previously approved these changes Jun 16, 2024

View reviewed changes

hugocostadev added 2 commits June 17, 2024 11:53

Merge branch 'develop' into feat/e2e-messages-mentions

9f4c217

Merge branch 'develop' into feat/e2e-messages-mentions

a97716a

Merge branch 'develop' into feat/e2e-messages-mentions

c8d67bf

hugocostadev marked this pull request as ready for review July 15, 2024 16:12

yash-rajpal previously approved these changes Jul 16, 2024

View reviewed changes

MarcosSpessatto requested changes Jul 22, 2024

View reviewed changes

apps/meteor/app/mentions/server/Mentions.ts Outdated Show resolved Hide resolved

apps/meteor/app/mentions/server/Mentions.ts Outdated Show resolved Hide resolved

apps/meteor/client/startup/e2e.ts Show resolved Hide resolved

apps/meteor/tests/e2e/e2e-encryption.spec.ts Show resolved Hide resolved

hugocostadev added 2 commits July 25, 2024 10:02

fix: isE2EEMessage helper usage

ad582e9

test: add user and channel test case

6e374c3

hugocostadev dismissed yash-rajpal’s stale review via 6e374c3 July 25, 2024 13:29

hugocostadev requested review from MarcosSpessatto and yash-rajpal July 25, 2024 13:30

hugocostadev added 2 commits July 25, 2024 10:43

Merge remote-tracking branch 'origin/develop' into feat/e2e-messages-…

887d710

…mentions

Merge remote-tracking branch 'origin/develop' into feat/e2e-messages-…

eed82a3

…mentions

milton-rucks modified the milestones: 7.0, 6.13 Aug 29, 2024

MarcosSpessatto approved these changes Aug 29, 2024

View reviewed changes

KevLehman approved these changes Aug 29, 2024

View reviewed changes

tassoevan approved these changes Sep 2, 2024

View reviewed changes

yash-rajpal approved these changes Sep 2, 2024

View reviewed changes

gabriellsh approved these changes Sep 13, 2024

View reviewed changes

jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Sep 17, 2024

dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 17, 2024

Merge branch 'develop' into feat/e2e-messages-mentions

1eeff2d

dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 17, 2024

ggazzo merged commit 274f4f5 into develop Sep 20, 2024
51 checks passed

ggazzo deleted the feat/e2e-messages-mentions branch September 20, 2024 00:15

rocketchat-github-ci mentioned this pull request Sep 20, 2024

Release 6.13.0 #33326

Merged

abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024

feat: E2EE messages mentions (#32510)

b1088cf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: E2EE messages mentions #32510

feat: E2EE messages mentions #32510

hugocostadev commented May 28, 2024 •

edited

Loading

dionisio-bot bot commented May 28, 2024 •

edited

Loading

changeset-bot bot commented May 28, 2024 •

edited

Loading

codecov bot commented May 28, 2024 •

edited

Loading

MarcosSpessatto left a comment

github-actions bot commented Sep 17, 2024 •

edited

Loading

feat: E2EE messages mentions #32510

feat: E2EE messages mentions #32510

Conversation

hugocostadev commented May 28, 2024 • edited Loading

Proposed changes (including videos or screenshots)

Acceptance criteria (DoD)

Issue(s)

Steps to test or reproduce

Further comments

dionisio-bot bot commented May 28, 2024 • edited Loading

changeset-bot bot commented May 28, 2024 • edited Loading

🦋 Changeset detected

codecov bot commented May 28, 2024 • edited Loading

Codecov Report

MarcosSpessatto left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024 • edited Loading

hugocostadev commented May 28, 2024 •

edited

Loading

dionisio-bot bot commented May 28, 2024 •

edited

Loading

changeset-bot bot commented May 28, 2024 •

edited

Loading

codecov bot commented May 28, 2024 •

edited

Loading

github-actions bot commented Sep 17, 2024 •

edited

Loading