Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proxified model props were missing context before attribution #32056

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 22, 2024

Fix proxified model props were missing context before attribution

it fixes the error during migration 304. Throwing Cannot read property 'finally' of undefined error.

closes #31635

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 22, 2024

🦋 Changeset detected

Latest commit: affa139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/livechat Minor
@rocket.chat/ddp-client Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/model-typings Patch
@rocket.chat/i18n Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/mock-providers Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo changed the base branch from release-6.5.4 to release-6.5.5 March 22, 2024 20:35
@ggazzo ggazzo force-pushed the fix/models-proxify branch 2 times, most recently from e6b3a7a to c10f66b Compare March 22, 2024 20:39
@ggazzo ggazzo force-pushed the fix/models-proxify branch from c10f66b to affa139 Compare March 22, 2024 20:44
@ggazzo ggazzo changed the base branch from release-6.5.5 to develop March 22, 2024 20:44
@ggazzo ggazzo marked this pull request as ready for review March 22, 2024 20:45
@ggazzo ggazzo requested a review from a team as a code owner March 22, 2024 20:45
@ggazzo ggazzo added this to the 6.7 milestone Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (9d23d40) to head (affa139).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32056      +/-   ##
===========================================
+ Coverage    54.70%   54.74%   +0.03%     
===========================================
  Files         2291     2298       +7     
  Lines        50618    50702      +84     
  Branches     10337    10354      +17     
===========================================
+ Hits         27690    27755      +65     
- Misses       20443    20455      +12     
- Partials      2485     2492       +7     
Flag Coverage Δ
e2e 53.76% <ø> (+0.06%) ⬆️
e2e-api 40.05% <ø> (-0.08%) ⬇️
unit 75.81% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 22, 2024
@kodiakhq kodiakhq bot merged commit e203c40 into develop Mar 22, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the fix/models-proxify branch March 22, 2024 21:49
This was referenced Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rocketchat update to 6.5.3 fails on first run (migration step 303 to 304)
3 participants