Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(Omnichannel): fix flaky units test #32050

Merged
merged 1 commit into from
Mar 21, 2024
Merged

test(Omnichannel): fix flaky units test #32050

merged 1 commit into from
Mar 21, 2024

Conversation

MartinSchoeler
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 21, 2024

⚠️ No Changeset found

Latest commit: d2c9a49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (c8b11da) to head (d2c9a49).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32050   +/-   ##
========================================
  Coverage    54.72%   54.73%           
========================================
  Files         2298     2298           
  Lines        50702    50702           
  Branches     10352    10352           
========================================
+ Hits         27748    27751    +3     
+ Misses       20459    20456    -3     
  Partials      2495     2495           
Flag Coverage Δ
e2e 53.80% <ø> (+0.07%) ⬆️
e2e-api 40.03% <ø> (-0.11%) ⬇️
unit 75.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 21, 2024 19:18
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner March 21, 2024 19:18
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 21, 2024
@ggazzo ggazzo merged commit 469afbd into develop Mar 21, 2024
47 checks passed
@ggazzo ggazzo deleted the unit-floky-fix branch March 21, 2024 21:36
@ggazzo ggazzo added this to the 6.7 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants