-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Add projection
and change promise calls to Promise.all
on LivechatAgentActivityMonitor
#32036
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32036 +/- ##
========================================
Coverage 54.72% 54.73%
========================================
Files 2298 2298
Lines 50702 50702
Branches 10352 10356 +4
========================================
+ Hits 27748 27752 +4
+ Misses 20459 20456 -3
+ Partials 2495 2494 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/app/livechat/server/statistics/LivechatAgentActivityMonitor.ts
Outdated
Show resolved
Hide resolved
projection
and change promise calls to Promise.all
on LivechatAgentActivityMonitorprojection
and change promise calls to Promise.all
on LivechatAgentActivityMonitor
CORE-215
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Add projection and change promise calls to Promise.all on LivechatAgentActivityMonitor. This should reduce the time for processing promises sequentially & reduce the data received from Mongo