Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add projection and change promise calls to Promise.all on LivechatAgentActivityMonitor #32036

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 20, 2024

CORE-215

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Add projection and change promise calls to Promise.all on LivechatAgentActivityMonitor. This should reduce the time for processing promises sequentially & reduce the data received from Mongo

Copy link

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 026e417

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (c8b11da) to head (026e417).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32036   +/-   ##
========================================
  Coverage    54.72%   54.73%           
========================================
  Files         2298     2298           
  Lines        50702    50702           
  Branches     10352    10356    +4     
========================================
+ Hits         27748    27752    +4     
+ Misses       20459    20456    -3     
+ Partials      2495     2494    -1     
Flag Coverage Δ
e2e 53.75% <ø> (+0.02%) ⬆️
e2e-api 40.12% <ø> (-0.02%) ⬇️
unit 75.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review March 21, 2024 17:34
@KevLehman KevLehman requested a review from a team as a code owner March 21, 2024 17:34
@MarcosSpessatto MarcosSpessatto changed the title chore: Add projection and change promise calls to Promise.all on LivechatAgentActivityMonitor refactor: Add projection and change promise calls to Promise.all on LivechatAgentActivityMonitor Mar 21, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 21, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 21, 2024
@kodiakhq kodiakhq bot merged commit d742b25 into develop Mar 21, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the chore/promise-all-projection branch March 21, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants