Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: UserCard alignment #32029

Merged
merged 2 commits into from
Mar 19, 2024
Merged

regression: UserCard alignment #32029

merged 2 commits into from
Mar 19, 2024

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris requested a review from a team as a code owner March 19, 2024 13:49
Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 1577c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.65%. Comparing base (5c4a972) to head (1577c8c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32029      +/-   ##
===========================================
+ Coverage    54.63%   54.65%   +0.01%     
===========================================
  Files         2297     2294       -3     
  Lines        50622    50582      -40     
  Branches     10319    10310       -9     
===========================================
- Hits         27659    27647      -12     
+ Misses       20473    20452      -21     
+ Partials      2490     2483       -7     
Flag Coverage Δ
e2e 53.73% <ø> (+0.01%) ⬆️
e2e-api 40.08% <ø> (+0.03%) ⬆️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 19, 2024
@dougfabris dougfabris added this to the 6.7 milestone Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@kodiakhq kodiakhq bot merged commit a8fd33a into develop Mar 19, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the reg/userCardAlignment branch March 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants