Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix Manual Selection - queue #32027

Merged
merged 3 commits into from
Mar 19, 2024
Merged

test: fix Manual Selection - queue #32027

merged 3 commits into from
Mar 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 19, 2024

multiple keys for the same thing can lead to mistakes, also not ideal because bypass the caches, in that way at least all the usequeries should behave same

ARCH-1281

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 1d9b37e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.64%. Comparing base (a8fd33a) to head (1882362).

❗ Current head 1882362 differs from pull request most recent head 1d9b37e. Consider uploading reports for the commit 1d9b37e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32027      +/-   ##
===========================================
+ Coverage    53.99%   54.64%   +0.65%     
===========================================
  Files         2268     2297      +29     
  Lines        50196    50621     +425     
  Branches     10249    10318      +69     
===========================================
+ Hits         27102    27661     +559     
+ Misses       20641    20466     -175     
- Partials      2453     2494      +41     
Flag Coverage Δ
e2e 53.70% <100.00%> (+1.31%) ⬆️
e2e-api 40.09% <ø> (-0.14%) ⬇️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title chore: solve omnichannel misusage of react-query test: fix Manual Selection - queue Mar 19, 2024
@ggazzo ggazzo added this to the 6.7 milestone Mar 19, 2024
@ggazzo ggazzo marked this pull request as ready for review March 19, 2024 20:43
@ggazzo ggazzo requested a review from a team as a code owner March 19, 2024 20:43
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@ggazzo ggazzo merged commit 71adf5c into develop Mar 19, 2024
8 of 9 checks passed
@ggazzo ggazzo deleted the chore/take-inquiry branch March 19, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants