Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(livechat): stop calling twice closeChat #32025

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 18, 2024

ARCH-1281

it seems that in extreme conditions (low cpu x slow network)
It is possible to call close chat more than once,
one caused by user interaction and the other by the message received via websocket. causing some navigation problems.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 40f4ea7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.58%. Comparing base (13fbf57) to head (40f4ea7).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32025   +/-   ##
========================================
  Coverage    54.58%   54.58%           
========================================
  Files         2295     2295           
  Lines        50575    50575           
  Branches     10327    10327           
========================================
  Hits         27608    27608           
- Misses       20470    20499   +29     
+ Partials      2497     2468   -29     
Flag Coverage Δ
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review March 18, 2024 23:03
@ggazzo ggazzo requested review from a team as code owners March 18, 2024 23:03
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 18, 2024
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That explains a lot lol

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@ggazzo ggazzo merged commit 443c63a into develop Mar 19, 2024
16 of 17 checks passed
@ggazzo ggazzo deleted the chore/livechat-duplicated-close-chat branch March 19, 2024 00:19
@ggazzo ggazzo added this to the 6.7 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants