Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix code typo in ddp-client readme #32023

Merged
merged 3 commits into from
Mar 20, 2024
Merged

docs: Fix code typo in ddp-client readme #32023

merged 3 commits into from
Mar 20, 2024

Conversation

gabriellsh
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 371a30d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.65%. Comparing base (78e95ab) to head (371a30d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32023      +/-   ##
===========================================
+ Coverage    54.60%   54.65%   +0.04%     
===========================================
  Files         2294     2297       +3     
  Lines        50589    50624      +35     
  Branches     10314    10321       +7     
===========================================
+ Hits         27625    27669      +44     
+ Misses       20475    20463      -12     
- Partials      2489     2492       +3     
Flag Coverage Δ
e2e 53.70% <ø> (+0.04%) ⬆️
e2e-api 40.15% <ø> (+0.08%) ⬆️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@ggazzo ggazzo merged commit 6e68f5a into develop Mar 20, 2024
45 checks passed
@ggazzo ggazzo deleted the fix/ddpClientDocs branch March 20, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants