Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Extra log on setDepartment API call when department provided is invalid #32020

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 18, 2024

SUP-502

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 18, 2024

⚠️ No Changeset found

Latest commit: 5f3d819

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (65b13d0) to head (5f3d819).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32020      +/-   ##
===========================================
+ Coverage    54.61%   54.62%   +0.01%     
===========================================
  Files         2293     2296       +3     
  Lines        50583    50601      +18     
  Branches     10321    10322       +1     
===========================================
+ Hits         27624    27640      +16     
- Misses       20467    20468       +1     
- Partials      2492     2493       +1     
Flag Coverage Δ
e2e 53.69% <ø> (+0.06%) ⬆️
e2e-api 40.05% <ø> (-0.09%) ⬇️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 18, 2024
@KevLehman KevLehman marked this pull request as ready for review March 18, 2024 18:21
@KevLehman KevLehman requested review from a team as code owners March 18, 2024 18:21
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 18, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 18, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@kodiakhq kodiakhq bot merged commit d0259a8 into develop Mar 19, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the chore/extra-log-setdepartment branch March 19, 2024 03:41
@scuciatto scuciatto added this to the 6.7 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants