Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: triggers being scheduled when user is already registered #31999

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Mar 14, 2024

introduced here: #31268
PROSVC-37

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 0b0c80c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: triggers being scheduled when user is already registered regression: triggers being scheduled when user is already registered Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (a222238) to head (0b0c80c).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31999      +/-   ##
===========================================
- Coverage    54.49%   54.48%   -0.01%     
===========================================
  Files         2294     2294              
  Lines        50554    50554              
  Branches     10323    10323              
===========================================
- Hits         27547    27545       -2     
+ Misses       20510    20509       -1     
- Partials      2497     2500       +3     
Flag Coverage Δ
e2e 53.50% <ø> (-0.02%) ⬇️
e2e-api 40.06% <ø> (+0.01%) ⬆️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the regression/trigger-schedule-error branch from 368afe4 to a12f1d6 Compare March 15, 2024 01:21
@ggazzo
Copy link
Member

ggazzo commented Mar 15, 2024

✘ 56 omnichannel/omnichannel-triggers-open-by-visitor.spec.ts:78:6 › OC - Livechat Triggers - Open by Visitor › OC - Livechat Triggers - after the visitor opens the chat the trigger message should not be visible neither after a page reload (8.1s)

@ggazzo ggazzo force-pushed the regression/trigger-schedule-error branch from 412caed to 0b0c80c Compare March 15, 2024 13:01
@ggazzo ggazzo added this to the 6.7 milestone Mar 15, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 15, 2024
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 15, 2024 14:04
@aleksandernsilva aleksandernsilva requested review from a team as code owners March 15, 2024 14:04
@ggazzo ggazzo merged commit 6f9624b into develop Mar 15, 2024
46 checks passed
@ggazzo ggazzo deleted the regression/trigger-schedule-error branch March 15, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants