Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: UnreadMessages bubble tweaks #31971

Merged
merged 3 commits into from
Mar 13, 2024
Merged

chore: UnreadMessages bubble tweaks #31971

merged 3 commits into from
Mar 13, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented Mar 12, 2024

DSAR-480

Proposed changes (including videos or screenshots)

  • Mark as read sentence case

  • close icon margins
    Screenshot 2024-03-12 at 16 22 43

  • plural/singular translations
    Screenshot 2024-03-12 at 16 23 02

  • bump fuselage with bubble margin adjusted

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 12, 2024

⚠️ No Changeset found

Latest commit: 0c59a8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.52%. Comparing base (9408ec8) to head (0c59a8c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31971   +/-   ##
========================================
  Coverage    54.52%   54.52%           
========================================
  Files         2294     2294           
  Lines        50557    50557           
  Branches     10324    10324           
========================================
  Hits         27566    27566           
+ Misses       20493    20491    -2     
- Partials      2498     2500    +2     
Flag Coverage Δ
e2e 53.53% <ø> (-0.07%) ⬇️
e2e-api 40.15% <ø> (+0.10%) ⬆️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti marked this pull request as ready for review March 12, 2024 20:46
@juliajforesti juliajforesti requested a review from a team as a code owner March 12, 2024 20:46
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2024
@kodiakhq kodiakhq bot merged commit 62adfc8 into develop Mar 13, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the chore/unread-indicator branch March 13, 2024 14:40
@juliajforesti juliajforesti added this to the 6.7 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants