Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: EmojiPicker wrong height calculation #31961

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 11, 2024

Proposed changes (including videos or screenshots)

before the fix

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 11, 2024

⚠️ No Changeset found

Latest commit: 344772f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris changed the title regression: EmojiPicker wrong size calculation regression: EmojiPicker wrong height calculation Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.48%. Comparing base (b9ef630) to head (344772f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31961      +/-   ##
===========================================
+ Coverage    54.46%   54.48%   +0.01%     
===========================================
  Files         2291     2291              
  Lines        50522    50519       -3     
  Branches     10317    10316       -1     
===========================================
+ Hits         27515    27523       +8     
+ Misses       20510    20502       -8     
+ Partials      2497     2494       -3     
Flag Coverage Δ
e2e 53.53% <ø> (+0.04%) ⬆️
e2e-api 40.00% <ø> (-0.03%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review March 11, 2024 21:26
@dougfabris dougfabris requested a review from a team as a code owner March 11, 2024 21:26
@dougfabris dougfabris added this to the 6.7 milestone Mar 11, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2024
@kodiakhq kodiakhq bot merged commit 6c92d10 into develop Mar 13, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the reg/emojiPicker-missplaced branch March 13, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants