chore: Create/Edit room consistency #31960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31960 +/- ##
===========================================
- Coverage 54.72% 54.28% -0.44%
===========================================
Files 2302 2251 -51
Lines 50755 49910 -845
Branches 10376 10160 -216
===========================================
- Hits 27777 27096 -681
+ Misses 20486 20344 -142
+ Partials 2492 2470 -22
Flags with carried forward coverage won't be shown. Click here to find out more. |
juliajforesti
force-pushed
the
chore/create-edit-rooms
branch
from
48051cd to
c8e342c
Compare
juliajforesti
force-pushed
the
chore/create-edit-rooms
branch
from
0060ff5 to
41a5f05
Compare
juliajforesti
force-pushed
the
chore/create-edit-rooms
branch
from
41a5f05 to
91337de
Compare
ggazzo
approved these changes
Apr 1, 2024
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Apr 4, 2024
* develop: (71 commits) fix: search room not reactive after room name changes (#32123) test: fix `should edit name of targetChannel` flaky test (#32121) fix: UI allowing to mark room as favorite despite room was not a `default` room (#32063) chore: Remove duplicated `ChannelDeletionTable` (#32114) test(livechat): fix Department flaky test (#32102) test(livechat): File upload settings (#32060) test: contact center after hook calling wrong endpoint (#32094) fix(livechat): registering guest multiple times cause message loss (#32069) test: allow csp for livechat tests (#32116) chore: Move portals to the portals folder (#32090) test: `InitialData.insertAdminUserFromEnv` (#32066) fix: `CSP` error right after `setInlineScriptsAllowed` (#32108) chore: Create/Edit room consistency (#31960) chore: Remove references to EE code from the app events (#31926) test(Livechat): Clean up after registerGuest() test (#32092) test: make presence api tests fully independent (#31782) test: make roles fully independent (#31783) chore: bump version to 7.0.0-develop test: make login api tests fully independent (#31786) fix!: api login should not suggest which credential is wrong (#32086) ...
|
Looks like this PR is not ready to merge, because of the following issues:
|
dionisio-bot
bot
added
stat: QA assured
|
Looks like this PR is not ready to merge, because of the following issues:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DSAR-435
Proposed changes (including videos or screenshots)
All users, including those with any disability, should face a consistent experience while creating/editing rooms. Such as:
Issue(s)
Closes #29017
Steps to test or reproduce
Further comments