Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: split scalability EE module into two #31942

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Mar 8, 2024

Proposed changes (including videos or screenshots)

Issue(s)

SUP-477

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: 92d52b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.56%. Comparing base (f438a14) to head (92d52b8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31942      +/-   ##
===========================================
- Coverage    54.63%   54.56%   -0.07%     
===========================================
  Files         2294     2291       -3     
  Lines        50563    50528      -35     
  Branches     10325    10320       -5     
===========================================
- Hits         27626    27573      -53     
- Misses       20438    20461      +23     
+ Partials      2499     2494       -5     
Flag Coverage Δ
e2e 53.61% <ø> (-0.11%) ⬇️
e2e-api 40.15% <ø> (-0.04%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review March 11, 2024 15:58
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner March 11, 2024 15:58
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may you please change the module name to just unlimited-presence?

@geekgonecrazy geekgonecrazy added this to the 6.7 milestone Mar 12, 2024
@casalsgh casalsgh requested a review from sampaiodiego March 12, 2024 19:30
geekgonecrazy
geekgonecrazy previously approved these changes Mar 12, 2024
sampaiodiego
sampaiodiego previously approved these changes Mar 12, 2024
ggazzo
ggazzo previously requested changes Mar 13, 2024
ee/packages/presence/src/Presence.ts Outdated Show resolved Hide resolved
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be considered a feat instead of a chore?

@pierre-lehnen-rc
Copy link
Contributor Author

Shouldn't this be considered a feat instead of a chore?

Maybe. I used chore because there's no feature change on the product itself - the feature is the same it's just activated by a different license module.

Copy link
Contributor

@geekgonecrazy geekgonecrazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 15, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 18, 2024
@kodiakhq kodiakhq bot merged commit aa384ce into develop Mar 18, 2024
43 checks passed
@kodiakhq kodiakhq bot deleted the chore/unlimited-presence-service branch March 18, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants