-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: split scalability EE module into two #31942
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31942 +/- ##
===========================================
- Coverage 54.63% 54.56% -0.07%
===========================================
Files 2294 2291 -3
Lines 50563 50528 -35
Branches 10325 10320 -5
===========================================
- Hits 27626 27573 -53
- Misses 20438 20461 +23
+ Partials 2499 2494 -5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may you please change the module name to just unlimited-presence
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be considered a feat
instead of a chore
?
41dcba0
Maybe. I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes (including videos or screenshots)
Issue(s)
SUP-477Steps to test or reproduce
Further comments