Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create RoomBody useFileUpload hook #31912

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 6, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: db3b92e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/useFileUpload branch from 54329b0 to db3b92e Compare March 6, 2024 16:49
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 54.61%. Comparing base (f9ee3cd) to head (db3b92e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31912      +/-   ##
===========================================
+ Coverage    54.57%   54.61%   +0.04%     
===========================================
  Files         2279     2281       +2     
  Lines        50205    50226      +21     
  Branches     10245    10246       +1     
===========================================
+ Hits         27399    27432      +33     
+ Misses       20317    20309       -8     
+ Partials      2489     2485       -4     
Flag Coverage Δ
e2e 53.57% <69.23%> (+0.05%) ⬆️
e2e-api 40.09% <ø> (+0.05%) ⬆️
unit 76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review March 6, 2024 17:24
@ggazzo ggazzo requested a review from a team as a code owner March 6, 2024 17:24
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 6, 2024
@kodiakhq kodiakhq bot merged commit e2fbfa1 into develop Mar 6, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the chore/useFileUpload branch March 6, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants