Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create Roombody useLeaderBanner hook #31911

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 6, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 7ca5307

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/useLeaderBanner branch from dcac754 to f0173db Compare March 6, 2024 16:43
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 54.64%. Comparing base (af4c81a) to head (79e453a).

❗ Current head 79e453a differs from pull request most recent head 7ca5307. Consider uploading reports for the commit 7ca5307 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31911      +/-   ##
===========================================
+ Coverage    54.60%   54.64%   +0.03%     
===========================================
  Files         2277     2284       +7     
  Lines        50146    50263     +117     
  Branches     10233    10253      +20     
===========================================
+ Hits         27382    27464      +82     
+ Misses       20313    20308       -5     
- Partials      2451     2491      +40     
Flag Coverage Δ
e2e 53.63% <58.82%> (+0.05%) ⬆️
e2e-api 40.07% <ø> (+0.03%) ⬆️
unit 76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/useLeaderBanner branch from f0173db to 79e453a Compare March 6, 2024 17:05
@ggazzo ggazzo marked this pull request as ready for review March 6, 2024 17:49
@ggazzo ggazzo requested a review from a team as a code owner March 6, 2024 17:49
dougfabris
dougfabris previously approved these changes Mar 6, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggazzo ggazzo force-pushed the chore/useLeaderBanner branch from 79e453a to 7ca5307 Compare March 6, 2024 18:49
@ggazzo ggazzo merged commit 3ca8f0d into develop Mar 6, 2024
5 of 7 checks passed
@ggazzo ggazzo deleted the chore/useLeaderBanner branch March 6, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants