Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move store scroll position to useRestoreScrollPosition (#31902) #31908

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 6, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: cbf9252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 54.65%. Comparing base (e2fbfa1) to head (cbf9252).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31908      +/-   ##
===========================================
+ Coverage    54.60%   54.65%   +0.04%     
===========================================
  Files         2277     2284       +7     
  Lines        50172    50251      +79     
  Branches     10237    10252      +15     
===========================================
+ Hits         27398    27465      +67     
- Misses       20293    20296       +3     
- Partials      2481     2490       +9     
Flag Coverage Δ
e2e 53.62% <75.00%> (+0.03%) ⬆️
e2e-api 40.13% <ø> (+0.08%) ⬆️
unit 76.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review March 6, 2024 17:18
@ggazzo ggazzo requested a review from a team as a code owner March 6, 2024 17:18
@ggazzo ggazzo force-pushed the chore/useRestoreScrollPosition branch from 53df974 to cbf9252 Compare March 6, 2024 17:46
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM!!!!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 6, 2024
@kodiakhq kodiakhq bot merged commit 3d1f755 into develop Mar 6, 2024
44 checks passed
@kodiakhq kodiakhq bot deleted the chore/useRestoreScrollPosition branch March 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants