Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove hardcoded position for message date #31866

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 1, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Mar 1, 2024

⚠️ No Changeset found

Latest commit: a2b26a3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo changed the title chore: remove hardcoded paddings for message date chore: remove hardcoded position for message date Mar 1, 2024
@ggazzo ggazzo marked this pull request as ready for review March 1, 2024 02:57
@ggazzo ggazzo requested a review from a team as a code owner March 1, 2024 02:57
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.55%. Comparing base (299aa15) to head (a2b26a3).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31866      +/-   ##
===========================================
- Coverage    54.59%   54.55%   -0.04%     
===========================================
  Files         2282     2280       -2     
  Lines        50246    50245       -1     
  Branches     10244    10244              
===========================================
- Hits         27431    27412      -19     
- Misses       20331    20347      +16     
- Partials      2484     2486       +2     
Flag Coverage Δ
e2e 53.47% <94.44%> (-0.10%) ⬇️
e2e-api 40.07% <ø> (+0.05%) ⬆️
unit 76.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 48d0410 into develop Mar 1, 2024
37 checks passed
@ggazzo ggazzo deleted the chore/date-scroll branch March 1, 2024 03:31
gabriellsh added a commit that referenced this pull request Mar 6, 2024
…tMarkdown

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: improve useJumpToMessage (#31907)
  feat: Add `link` action to composer toolbar (#31679)
  chore: replace `PaletteStyleTag` in favor of fuselage component (#31839)
  fix: presence for mobiles with duplicated connections (#31895)
  fix: New users are not automatically inserted in auto-join rooms inside default teams (#31720)
  fix: livechat agent status set to available after reactivation (#31651)
  chore: Deprecate `insertOrUpdateUser` method (#31884)
  chore: update ts version on recently merged package (#31885)
  chore: move utilitary functions out of ee folder (#31207)
  chore: Remove references to EE code from the app bridges (#31757)
  fix: Room import doesn't honor the specified owner (#31803)
  fix: message parser emphasis black hole (#31868)
  chore: remove hardcoded position for message date (#31866)
  feat: show date on message's scroll (#31572)
  chore: `RoomHeader` keyboard navigability (#31837)
  fix: Login page breaking when handling not expected errors (#31804)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant