Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Prevent storing lastFocused message by click event #31819

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 23, 2024

⚠️ No Changeset found

Latest commit: 3d487d0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris added this to the 6.7 milestone Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.49%. Comparing base (5ff4110) to head (3d487d0).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31819      +/-   ##
===========================================
- Coverage    54.53%   54.49%   -0.04%     
===========================================
  Files         2274     2272       -2     
  Lines        50107    50106       -1     
  Branches     10220    10219       -1     
===========================================
- Hits         27324    27305      -19     
- Misses       20310    20326      +16     
- Partials      2473     2475       +2     
Flag Coverage Δ
e2e 53.45% <100.00%> (-0.01%) ⬇️
e2e-api 39.85% <ø> (-0.09%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the reg/lastFocusedByClick branch from 989198f to 919c768 Compare February 23, 2024 16:02
@dougfabris dougfabris marked this pull request as ready for review February 23, 2024 17:06
@dougfabris dougfabris requested a review from a team as a code owner February 23, 2024 17:06
@ggazzo ggazzo merged commit 7d331f1 into develop Feb 23, 2024
43 checks passed
@ggazzo ggazzo deleted the reg/lastFocusedByClick branch February 23, 2024 17:52
gabriellsh added a commit that referenced this pull request Feb 29, 2024
…LinkAction

* 'develop' of github.com:RocketChat/Rocket.Chat: (41 commits)
  fix: Login page breaking when handling not expected errors (#31804)
  chore: Upgrade `react-virtuoso` (#31843)
  chore: Refactor & Improve Livechat Widget API (#30924)
  i18n: Rocket.Chat.Livechat language update from LingoHub 🤖 on 2024-02-28Z (#31855)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-02-28Z (#31856)
  chore: Sidebar toolbar keyboard navigation (#31846)
  fix(eslint-config): react config file export (#31845)
  chore: cache ui-context package (#31805)
  fix: make lifecycle methods part of inherited class in federation services (#31844)
  fix: client ignoring offline presence updates (#31833)
  test: saml login custom role (#31830)
  chore: `VideoConfPopup` keyboard navigability (#31831)
  fix: revert status websocket payload changes (#31823)
  chore: `UserCard` focus improvements (#31812)
  regression: Prevent storing lastFocused message by click event (#31819)
  chor: allow offline development build
  test: make calendar api tests fully independent (#31785)
  fix: Correct display of discussion names in sidebar search (#31701)
  bump meteor 2.15 (#31799)
  test: make apps api tests fully independent (#31787)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants