Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(message-parser): add timestamps pattern #31810

Merged
merged 11 commits into from
Mar 8, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 21, 2024

CORE-140

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: 440089b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/message-parser Patch
@rocket.chat/meteor Patch
@rocket.chat/core-services Patch
@rocket.chat/core-typings Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/rest-typings Patch
rocketchat-services Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.49%. Comparing base (b876e4e) to head (440089b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31810      +/-   ##
===========================================
- Coverage    54.52%   54.49%   -0.03%     
===========================================
  Files         2286     2289       +3     
  Lines        50327    50386      +59     
  Branches     10269    10293      +24     
===========================================
+ Hits         27441    27460      +19     
- Misses       20399    20428      +29     
- Partials      2487     2498      +11     
Flag Coverage Δ
e2e 53.46% <100.00%> (-0.03%) ⬇️
e2e-api 40.01% <ø> (-0.04%) ⬇️
unit 76.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 22, 2024 13:04
@ggazzo ggazzo requested a review from a team as a code owner February 22, 2024 13:04
@ggazzo ggazzo requested a review from a team as a code owner February 23, 2024 19:28
@ggazzo ggazzo force-pushed the feat/message-parser-timestamp branch 5 times, most recently from 29363ce to feb1a58 Compare February 28, 2024 17:42
@ggazzo ggazzo force-pushed the feat/message-parser-timestamp branch from feb1a58 to 5b3afe3 Compare March 1, 2024 21:32
@ggazzo ggazzo force-pushed the feat/message-parser-timestamp branch from 5b3afe3 to e093234 Compare March 7, 2024 03:48
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 8, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 8, 2024
@kodiakhq kodiakhq bot merged commit 5ad65ff into develop Mar 8, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the feat/message-parser-timestamp branch March 8, 2024 23:51
gabriellsh added a commit that referenced this pull request Mar 12, 2024
…modalRegions

* 'develop' of github.com:RocketChat/Rocket.Chat: (77 commits)
  fix: CRM integration mismatch on callback type (#31880)
  test: make outgoing integrations fully independent (#31656)
  fix: setDepartment not persisting on chat closed (#31792)
  fix: Trigger app event after inquiry is created (#31909)
  regression: Favorite action announcement (#31940)
  regression: Prevents `ImageGallery` to restore focus on message (#31869)
  i18n: Add missing swedish translation for "Create direct message" key (#31945)
  feat(message-parser): add timestamps pattern (#31810)
  fix: convert network broker stopped lifecycle method to async (#31927)
  regression: undefined guest causing issues (#31932)
  refactor: use uiContexts on livechat (#31919)
  fix: Validate rooms are not taken before processing by queue (#31896)
  fix: livechat sdk reconnect not resubscribing (#31941)
  fix: Quote attachments are not deleted on message update (#31660)
  Revert "regression: Favorite action announcement" (#31935)
  chore: improve room `LeaderBar` behavior with date bubble (#31933)
  regression: Favorite action announcement (#31934)
  chore: Migrate notifyUsersOnMessage to TypeScript (#31877)
  fix: Mentions stop working when mentioned user changes username (#31860)
  regression: `RoomBody` unread and new messages behavior (#31929)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants