Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing packages to ddp-client #31801

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 21, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Feb 21, 2024

⚠️ No Changeset found

Latest commit: 684b39e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo force-pushed the chore/ddp-client-deps branch from 1181d09 to ba4b165 Compare February 21, 2024 03:43
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ff4110) 54.50% compared to head (684b39e) 54.47%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31801      +/-   ##
===========================================
- Coverage    54.50%   54.47%   -0.03%     
===========================================
  Files         2274     2275       +1     
  Lines        50107    50138      +31     
  Branches     10220    10226       +6     
===========================================
+ Hits         27309    27315       +6     
- Misses       20326    20342      +16     
- Partials      2472     2481       +9     
Flag Coverage Δ
e2e 53.42% <ø> (-0.04%) ⬇️
e2e-api 39.85% <ø> (ø)
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review February 21, 2024 14:33
@ggazzo ggazzo merged commit be9dc38 into develop Feb 21, 2024
43 checks passed
@ggazzo ggazzo deleted the chore/ddp-client-deps branch February 21, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants