Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make api methods test fully independent #31742

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Feb 12, 2024

https://rocketchat.atlassian.net/browse/CORE-168

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner February 12, 2024 20:44
Copy link

changeset-bot bot commented Feb 12, 2024

⚠️ No Changeset found

Latest commit: 01ae48a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb9c6ba) 54.33% compared to head (01ae48a) 54.41%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31742      +/-   ##
===========================================
+ Coverage    54.33%   54.41%   +0.08%     
===========================================
  Files         2276     2276              
  Lines        50124    50124              
  Branches     10220    10220              
===========================================
+ Hits         27233    27276      +43     
+ Misses       20406    20371      -35     
+ Partials      2485     2477       -8     
Flag Coverage Δ
e2e 53.28% <ø> (+0.11%) ⬆️
e2e-api 39.90% <ø> (+0.07%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 8daf5d4 into develop Feb 15, 2024
43 checks passed
@ggazzo ggazzo deleted the test/decouple-methods branch February 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants