Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make subscription test fully independent #31673

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Feb 7, 2024

https://rocketchat.atlassian.net/browse/CORE-155

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner February 7, 2024 15:22
Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 306fe41

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1bc9f6) 54.37% compared to head (306fe41) 54.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31673      +/-   ##
===========================================
- Coverage    54.37%   54.35%   -0.03%     
===========================================
  Files         2278     2276       -2     
  Lines        50102    50057      -45     
  Branches     10210    10211       +1     
===========================================
- Hits         27244    27208      -36     
+ Misses       20383    20367      -16     
- Partials      2475     2482       +7     
Flag Coverage Δ
e2e 53.16% <ø> (-0.06%) ⬇️
e2e-api 39.91% <ø> (+0.01%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 7, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 7, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 7, 2024
@kodiakhq kodiakhq bot merged commit 6ada486 into develop Feb 8, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the test/decouple-subscriptions branch February 8, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants