Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Freezes permissions table first column #31626

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Feb 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

WM-192

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: 40c1fb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.7 milestone Feb 2, 2024
@dougfabris dougfabris marked this pull request as ready for review February 2, 2024 20:08
@dougfabris dougfabris requested a review from a team as a code owner February 2, 2024 20:08
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de6997e) 52.54% compared to head (40c1fb8) 54.40%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31626      +/-   ##
===========================================
+ Coverage    52.54%   54.40%   +1.85%     
===========================================
  Files         2210     2279      +69     
  Lines        48487    50120    +1633     
  Branches      9858    10227     +369     
===========================================
+ Hits         25478    27266    +1788     
+ Misses       20665    20370     -295     
- Partials      2344     2484     +140     
Flag Coverage Δ
e2e 53.21% <ø> (+3.62%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@kodiakhq kodiakhq bot merged commit c2ca061 into develop Feb 5, 2024
42 checks passed
@kodiakhq kodiakhq bot deleted the fix/permissionTableColumn branch February 5, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants