Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make autotranslate api tests fully independent #31581

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Jan 30, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/CORE-144

Copy link

changeset-bot bot commented Jan 30, 2024

⚠️ No Changeset found

Latest commit: 82df607

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0d7753c) 54.35% compared to head (82df607) 48.79%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31581      +/-   ##
===========================================
- Coverage    54.35%   48.79%   -5.57%     
===========================================
  Files         2273     1914     -359     
  Lines        50044    43519    -6525     
  Branches     10347     8782    -1565     
===========================================
- Hits         27202    21235    -5967     
+ Misses       20364    20340      -24     
+ Partials      2478     1944     -534     
Flag Coverage Δ
e2e 40.94% <ø> (-12.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's great initiative.. much appreciated 🤗

the PR title should be test: make autotranslate api tests fully independent

there are a few places were a Promise.all() could've been used.. not sure how much that actually affects performance though (I'd expect them to run faster but no sure by how much)

apps/meteor/tests/end-to-end/api/00-autotranslate.js Outdated Show resolved Hide resolved
@MarcosSpessatto MarcosSpessatto changed the title chore: make autotranslate api tests fully independent test: make autotranslate api tests fully independent Jan 31, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@kodiakhq kodiakhq bot merged commit 387c771 into develop Feb 5, 2024
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the chore/decouple-api-tests branch February 5, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants