-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: make autotranslate api tests fully independent #31581
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31581 +/- ##
===========================================
- Coverage 54.35% 48.79% -5.57%
===========================================
Files 2273 1914 -359
Lines 50044 43519 -6525
Branches 10347 8782 -1565
===========================================
- Hits 27202 21235 -5967
+ Misses 20364 20340 -24
+ Partials 2478 1944 -534
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's great initiative.. much appreciated 🤗
the PR title should be test: make autotranslate api tests fully independent
there are a few places were a Promise.all()
could've been used.. not sure how much that actually affects performance though (I'd expect them to run faster but no sure by how much)
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CORE-144