Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dryrun option sending email to all queried users #31571

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Jan 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/SUP-446

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: 4952b1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (08df231) 49.55% compared to head (4952b1a) 49.56%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31571   +/-   ##
========================================
  Coverage    49.55%   49.56%           
========================================
  Files         3323     3325    +2     
  Lines        81756    81784   +28     
  Branches     16874    16884   +10     
========================================
+ Hits         40517    40533   +16     
- Misses       36500    36504    +4     
- Partials      4739     4747    +8     
Flag Coverage Δ
e2e 53.26% <ø> (-0.01%) ⬇️
e2e-api 40.65% <0.00%> (+<0.01%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review January 29, 2024 12:57
@hugocostadev hugocostadev added this to the 6.7 milestone Jan 29, 2024
hugocostadev
hugocostadev previously approved these changes Jan 29, 2024
@tapiarafael tapiarafael requested a review from a team as a code owner January 29, 2024 14:57
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 29, 2024
@kodiakhq kodiakhq bot merged commit 2c0260d into develop Jan 29, 2024
46 checks passed
@kodiakhq kodiakhq bot deleted the fix/mailer-dryrun branch January 29, 2024 19:01
aleksandernsilva pushed a commit that referenced this pull request Feb 2, 2024
MartinSchoeler pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants