Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Decouple WebDAV accounts integration from client initialization #31553

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jan 26, 2024

⚠️ No Changeset found

Latest commit: 791ca65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (2c0260d) 49.55% compared to head (791ca65) 49.52%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31553      +/-   ##
===========================================
- Coverage    49.55%   49.52%   -0.03%     
===========================================
  Files         3324     3327       +3     
  Lines        81753    81854     +101     
  Branches     16878    16899      +21     
===========================================
+ Hits         40510    40536      +26     
- Misses       36501    36574      +73     
- Partials      4742     4744       +2     
Flag Coverage Δ
e2e 53.18% <48.93%> (-0.11%) ⬇️
e2e-api 40.63% <ø> (+<0.01%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/client-startup-2 branch from a770526 to 5d16302 Compare January 27, 2024 03:45
@tassoevan tassoevan force-pushed the refactor/client-startup-2 branch from 5d16302 to e81598a Compare January 29, 2024 16:01
@tassoevan tassoevan marked this pull request as ready for review January 29, 2024 18:06
@tassoevan tassoevan requested a review from a team as a code owner January 29, 2024 18:06
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tassoevan tassoevan added this to the 6.7 milestone Jan 31, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 31, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 31, 2024
@kodiakhq kodiakhq bot merged commit 0ff92dc into develop Jan 31, 2024
42 checks passed
@kodiakhq kodiakhq bot deleted the refactor/client-startup-2 branch January 31, 2024 16:22
ggazzo pushed a commit that referenced this pull request Feb 1, 2024
ggazzo pushed a commit that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants