Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce new methods to fetch rooms on Livechat Bridge #31538

Merged
merged 17 commits into from
Mar 15, 2024

Conversation

lmauromb
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

@lmauromb lmauromb added this to the 6.7 milestone Jan 25, 2024
@lmauromb lmauromb requested a review from KevLehman January 25, 2024 17:43
Copy link

changeset-bot bot commented Jan 25, 2024

🦋 Changeset detected

Latest commit: b9805e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.46%. Comparing base (a222238) to head (b9805e1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31538      +/-   ##
===========================================
- Coverage    54.49%   54.46%   -0.03%     
===========================================
  Files         2294     2290       -4     
  Lines        50554    50508      -46     
  Branches     10323    10322       -1     
===========================================
- Hits         27547    27511      -36     
+ Misses       20510    20499      -11     
- Partials      2497     2498       +1     
Flag Coverage Δ
e2e 53.45% <ø> (-0.07%) ⬇️
e2e-api 40.10% <ø> (+0.04%) ⬆️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

apps/meteor/app/apps/server/bridges/livechat.ts Outdated Show resolved Hide resolved
apps/meteor/app/apps/server/bridges/livechat.ts Outdated Show resolved Hide resolved
@lmauromb lmauromb requested a review from KevLehman January 29, 2024 16:42
@lmauromb lmauromb requested a review from KevLehman January 29, 2024 19:29
KevLehman
KevLehman previously approved these changes Jan 29, 2024
@lmauromb lmauromb marked this pull request as ready for review January 30, 2024 20:57
@lmauromb lmauromb requested review from a team as code owners January 30, 2024 20:57
@lmauromb lmauromb marked this pull request as draft January 30, 2024 20:58
@lmauromb lmauromb marked this pull request as ready for review February 9, 2024 19:48
@lmauromb lmauromb requested a review from a team as a code owner February 15, 2024 15:22
@d-gubert
Copy link
Member

Just a note for the future: whenever updating the Apps-Engine, you can run a yarn up @rocket.chat/[email protected] at the root of the project - this will update the dependency in all packages inside the monorepo to the same version.

Of course, this also works for any other package that is used throughout the monorepo :)

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 8, 2024
KevLehman
KevLehman previously approved these changes Mar 11, 2024
@lmauromb lmauromb dismissed stale reviews from KevLehman and MarcosSpessatto via d0acd50 March 13, 2024 15:02
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 13, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 15, 2024
@kodiakhq kodiakhq bot merged commit 5484c41 into develop Mar 15, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the add-agent-active-rooms-to-bridge branch March 15, 2024 13:58
MartinSchoeler pushed a commit that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants