feat: access-marketplace permission #29203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #29203 +/- ##
===========================================
- Coverage 46.71% 45.98% -0.74%
===========================================
Files 698 685 -13
Lines 13075 12988 -87
Branches 2227 2209 -18
===========================================
- Hits 6108 5972 -136
- Misses 6649 6708 +59
+ Partials 318 308 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
requested changes
May 16, 2023
🦋 Changeset detectedLatest commit: 0646b89 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gabriellsh
previously approved these changes
May 19, 2023
tiagoevanp
reviewed
May 23, 2023
There was a problem hiding this comment.
I have a question, why we are fixing permissions for admin and users only? What kind of role shouldn't be able to visit marketplace view since we are trying to expose the apps? The code looks fine to me, but I want to have better explanation about the reason for this PR to accept it... 🤔
tiagoevanp
previously approved these changes
May 23, 2023
We added this new permission as default for regular users, it doesn't change behaviour, but now if an admin wants to remove this permission, they can do it. |
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
approved these changes
Jun 1, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
This was referenced Jun 2, 2023
aleksandernsilva
pushed a commit
that referenced
this pull request
Jun 6, 2023
gabriellsh
added a commit
that referenced
this pull request
Jun 6, 2023
…importer-messages-not-shown * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Room history scroll position (#29335) fix: check for $addToSet to be not empty before passing update params (#29378) chore: update `badge-level-0` color (#29460) fix: Saving Business hour throws an alert (#29449) regression: emojiPicker position (#29408) chore: Update codeowners to add ownership of rest typings package to backend (#29437) fix: Removed agent access to already taken rooms (#28979) fix: `queuedForUser` endpoint not filtering by status (#29189) regression: Marketplace Selectors (#29443) chore: fix contextualbar size (#29441) chore: `ComposerBoxPopup` Items alignment (#29320) feat: add support for `MONOLITH_TRANSPORTER` env var (#29373) fix: Import progress page stuck at 0% (#29421) feat: access-marketplace permission (#29203) chore(ddp-client): freeze data emitted by the sdk (#29430) refactor: `Table` on Integrations Page (#29428) regression: Update `LoadingIndicator` colors (#29424) chore(meteor): Update mention style (#29426)
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
access-marketplace permission for marketplace section
Issue(s)
Steps to test or reproduce
Further comments
TC-626