Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Incomplete emails are being accepted at user registration #29115

Merged
merged 20 commits into from
Jun 16, 2023
Merged

fix: Incomplete emails are being accepted at user registration #29115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
e7bfdb2
work in progress
felipe-rod123 May 2, 2023
424ba52
add Error to input box
felipe-rod123 May 4, 2023
9306125
Remove console.logs
felipe-rod123 May 4, 2023
9bd6461
fix lint
felipe-rod123 May 8, 2023
b6b2582
fix emailInput and add useDebouncedValue
felipe-rod123 May 15, 2023
d1947b0
change useDebounced time and useForm validation
felipe-rod123 May 19, 2023
a1ae2a6
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev May 25, 2023
eb28b1e
fix review
felipe-rod123 May 25, 2023
367dcd1
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev May 30, 2023
bd5dc6e
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev May 31, 2023
73b1225
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
kodiakhq[bot] May 31, 2023
0c07bd6
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
kodiakhq[bot] May 31, 2023
f1897f4
Create incomplete-emails.md
felipe-rod123 Jun 7, 2023
5e0cb68
fix: simplified changeset
hugocostadev Jun 12, 2023
ff7b390
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev Jun 12, 2023
a2288c7
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
casalsgh Jun 12, 2023
f75782c
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev Jun 13, 2023
de515a5
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev Jun 14, 2023
587bd0f
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev Jun 14, 2023
22c132b
Merge branch 'develop' into fix/incomplete-emails-at-user-registration
hugocostadev Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/incomplete-emails.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/web-ui-registration": patch
---

✅ Added a new email validation in the Registration Form
6 changes: 5 additions & 1 deletion packages/web-ui-registration/src/RegisterForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,13 @@ export const RegisterForm = ({ setLoginRoute }: { setLoginRoute: DispatchLoginRo
<TextInput
{...register('email', {
required: true,
pattern: {
value: /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,}$/i,
message: t('registration.component.form.invalidEmail'),
},
})}
placeholder={usernameOrEmailPlaceholder || t('registration.component.form.emailPlaceholder')}
error={errors.email && t('registration.component.form.requiredField')}
error={errors.email && t('registration.component.form.invalidEmail')}
name='email'
aria-invalid={errors.email ? 'true' : undefined}
id='email'
Expand Down