Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Multi instance error message #27243

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Nov 11, 2022

Proposed changes (including videos or screenshots)

Issue(s)

ARCH-88

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner November 11, 2022 18:17
@sampaiodiego sampaiodiego added this to the 5.3.1 milestone Nov 11, 2022
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Nov 11, 2022
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #27243 (73d8a90) into develop (1c5f950) will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27243      +/-   ##
===========================================
+ Coverage    40.89%   41.71%   +0.81%     
===========================================
  Files          854      826      -28     
  Lines        18751    18258     -493     
  Branches      2053     1989      -64     
===========================================
- Hits          7669     7616      -53     
+ Misses       10791    10356     -435     
+ Partials       291      286       -5     
Flag Coverage Δ
e2e 41.71% <ø> (+0.81%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 01ed98e into develop Nov 11, 2022
@kodiakhq kodiakhq bot deleted the fix-multi-instance-message branch November 11, 2022 20:36
bkrith pushed a commit to bkrith/Rocket.Chat that referenced this pull request Nov 12, 2022
ggazzo pushed a commit that referenced this pull request Nov 14, 2022
@ggazzo ggazzo mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants