Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Do not count Matrix federated users as a valid EE seat #26525

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Aug 9, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Matrix federated (external) users were being counted as a valid EE seat.

Steps to test or reproduce

Further comments

@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #26525 (96f81b1) into improve/federation-general-improvements (24ac9c4) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@                             Coverage Diff                             @@
##           improve/federation-general-improvements   #26525      +/-   ##
===========================================================================
- Coverage                                    38.07%   37.98%   -0.10%     
===========================================================================
  Files                                          745      745              
  Lines                                        18625    18625              
  Branches                                      1412     1412              
===========================================================================
- Hits                                          7091     7074      -17     
- Misses                                       11313    11330      +17     
  Partials                                       221      221              
Flag Coverage Δ
e2e 37.98% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MarcosSpessatto MarcosSpessatto added this to the 5.1.0 milestone Aug 9, 2022
@alansikora alansikora merged commit 3ebbc82 into improve/federation-general-improvements Aug 10, 2022
@alansikora alansikora deleted the fix/do-not-count-federated-users-on-license branch August 10, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants